Conversation
maxdobler
reviewed
Dec 13, 2019
Contributor
maxdobler
left a comment
maxdobler
left a comment
There was a problem hiding this comment.
hab paar kleine anmerkungen
Comment on lines
+119
to
+121
| if (calendarId == -1L) { | ||
| calendarId = preferencesService.getCalendarIdOfLastSelectedRoom(); | ||
| } |
Contributor
There was a problem hiding this comment.
duplicated code from line 83
| @@ -191,7 +233,7 @@ public void onBackPressed() { | |||
| switch (navigationController.getSelectedFragment()) { | |||
Contributor
There was a problem hiding this comment.
Maybe delegate this logik to the navigation controller
| Long defaultRoom = preferencesService.getCalendarIdOfDefaultRoom(); | ||
|
|
||
| // if no default room set, use last selected room | ||
| if (defaultRoom == -1L) { |
Contributor
There was a problem hiding this comment.
-1 finde ich nicht so gut, könnten wir da nicht was anderes nehemen? Enum z.B.
heetel
force-pushed
the
auto-navigate-to-status
branch
from
eb7b64c to
1085440
Compare
heetel
force-pushed
the
auto-navigate-to-status
branch
from
1085440 to
97c03e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.