Fix issues with several TAP tests - Closes #4830 #4881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of connections being maintained by the test now assumes (number_of_intervals - 1). This spare interval decreases the number of connections actively maintained and should make the test more resilient in to small network stalls.
Test requires a MySQL 8 instance, this is now parametrized via TAP_MYSQL8_BACKEND_HG env variable as in other TAP tests.
Also adds a status variable exporting the OpenSSL version in use.
- Deterministic test table: Invalid limits and tables with variable
rows ('information_schema') were used to create the original table
size, this is now replaced with a deterministic table.
- Compression overhead measurement: Previous test design generated a
very large resultset (> 20Gb), performing a single measurement per
resultset. This resulted in very inaccurate measurements, with radical
variations between different systems. A resultset of the previous size
can interfere in multiple ways with measurements, like network
saturation, bufferbloat, and queuing delays at application level, all
things that are out of the scope of the test measurement. This have
been reworked into multiple smaller packets (40Mb) big enough so that
the increased latency of compression can be measured and averaged.
- Fixed test checks: Previous test checks were meaningless, performing
only a non-zero comparison between performance differences. This gave
no insights about ProxySQL vs MySQL differences or allowed for simple
coherence checks (non-compress time < compress time). All these checks
have new confidence ranges based on experimental values.
- Improved general logging based on other TAP tests conventions and
refactored most of the functions.
JavierJF
force-pushed
the
v3.0-ci_fixes_172
branch
from
dd21b47 to
1aaa16a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some consistency issues or design problems found with the following tests:
set_character_set-ttest_backend_conn_ping-tset_testing-240-ttest_utf8mb4_as_ci-4841-ttest_backend_conn_ping-ttest_cacert_load_and_verify_duration-tmysql-protocol_compression_level-tIt also addresses the request for adding warning messages on #4830.