Fix delete connection with incorrect index

[Gonlo2]

This PR solves the problem of removing an incorrect connection.

A clear description of the issue

The first connection in the list is always deleted when it appears that the one with index i is to be deleted.

ProxySQL version

v3.0.2

The steps to reproduce the issue

This error was detected by a manual inspection of the code, so I don't know what could be causing it.

[gemini-code-assist]

Summary of Changes

Hello @Gonlo2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the connection management system that was causing the wrong database connection to be deleted. The fix ensures that the intended connection, identified by its correct index, is removed, thereby preventing unintended disconnections and maintaining system stability.

Highlights

• Fix incorrect connection deletion: Corrected an issue in the connection management logic where the remove function was inadvertently always deleting the first connection in the list (at index 0), instead of the specific connection at the intended index i.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[renecannao]

Can one of the admins verify this patch?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request fixes a critical bug in the drop_all_idle_connections function. The original code incorrectly removed the connection at index 0 instead of the expired connection at the current loop index i. The change to use mscl->remove(i) is correct and ensures proper connection pool management by removing the correct expired connections. This prevents stale connections from lingering and valid connections from being dropped prematurely. The fix is accurate and I approve it.