Fix Symbol.ranges unpacking #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Symbol.ranges attribute in kconfiglib returns 4-tuples (low, high, cond, loc), but menuconfig and guiconfig were using the old 3-tuple unpacking pattern, causing ValueError when processing integer/hex symbols with range properties. Changes: - Update all sym.ranges unpacking to handle 4-tuple format - Use underscore (_) for unused location parameter to indicate intent - Standardize on sym.orig_type instead of sym.type for consistency with kconfiglib internals and to avoid potential issues with type transformations
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Symbol.ranges attribute in kconfiglib returns 4-tuples (low, high, cond, loc), but menuconfig and guiconfig were using the old 3-tuple unpacking pattern, causing ValueError when processing integer/hex symbols with range properties.
Changes:
Summary by cubic
Fix crashes in menuconfig and guiconfig when handling INT/HEX symbol ranges by aligning with kconfiglib’s current API. Users can now enter values without ValueError.