Improve the Makefile speed by simple assignment #628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I Live in slow and bad network environments, recursive variable assignments (
=) in the Makefile can cause shell commands, such aswgetforLINUX_DATA, to execute multiple times, significantly slowing down the build process.How
By using simple assignment (
:=),wgetis executed only once during Makefile parsing. This reduces redundant network requests and improves overall Makefile execution speed.How to Debug
make check SHELL="/bin/bash -x -e -o pipefail"Before
Terminal Output
After
Terminal Output
References
Summary by cubic
Switch LINUX_DATA and LINUX_DATA_SHA to simple assignment (:=) so wget runs once at parse time. This prevents repeated downloads and speeds up builds, especially on slow networks.