Skip to content

debian: add new split-out systemd packages#4388

Open
bluca wants to merge 1 commit into
systemd:mainfrom
bluca:new_pkgs
Open

debian: add new split-out systemd packages#4388
bluca wants to merge 1 commit into
systemd:mainfrom
bluca:new_pkgs

Conversation

@bluca

@bluca bluca commented Jul 3, 2026

Copy link
Copy Markdown
Member

Tools and services related to tpm, imds and report were split out in new subpackages to reduce the default dependencies. Adjust the package lists accordingly.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Claude review of PR #4388 (4812c89)

This is a clean, config-only change. The [Match][TriggerMatch] conversion and the negation logic are mechanically correct (the ANDed Release=!x conditions and the libtss/systemd-tpm complementarity partition the release space cleanly, and dropping kali from libtss is right since rolling kali always has the split package). The one substantive concern is that the Ubuntu release enumeration only covers the LTS releases, leaving interim releases in the split-package branch.

Must fix

  • Ubuntu interim releases not excludedmkosi/resources/mkosi-initrd/mkosi.conf.d/debian-kali-ubuntu/mkosi.conf.d/systemd-tpm.conf:13 — negation list excludes only LTS releases; oracular/plucky/questing predate the ubuntu26.10 split and would try to install a non-existent systemd-tpm.
  • Ubuntu interim releases not excludedmkosi/resources/mkosi-initrd/mkosi.profiles/network/mkosi.conf.d/debian-kali-ubuntu/mkosi.conf.d/systemd-imds.conf:13 — same gap for systemd-imds.
  • Ubuntu interim releases not excludedmkosi/resources/mkosi-vm/mkosi.conf.d/debian-kali-ubuntu/mkosi.conf.d/systemd-tpm-imds-report.conf:13 — same gap for all three split packages.

Suggestions

  • libtss inclusion list has same gapmkosi/resources/mkosi-initrd/mkosi.conf.d/debian-kali-ubuntu/mkosi.conf.d/libtss.conf:14 — interim Ubuntu releases lose the libtss2 libs they used to get by default.
  • Redundant nested directorymkosi/resources/mkosi-initrd/mkosi.profiles/network/mkosi.conf.d/debian-kali-ubuntu/mkosi.conf:3systemd-imds.conf could live flat in network/mkosi.conf.d/ like its sibling systemd-resolved.conf, dropping the extra subtree and parent [Match].

Nits

  • Inline Packages= formattingmkosi/resources/mkosi-vm/mkosi.conf.d/debian-kali-ubuntu/mkosi.conf.d/systemd-tpm-imds-report.conf:19 — other multi-package files use an empty Packages= line with indented entries.
  • Package entries indented with 9 spacesmkosi/resources/mkosi-vm/mkosi.conf.d/debian-kali-ubuntu/mkosi.conf.d/systemd-tpm-imds-report.conf:20 — the reformatted list indents entries with 9 spaces; every other continuation line in the resources uses 8.

Workflow run

Tools and services related to tpm, imds and report were split out in
new subpackages to reduce the default dependencies. Adjust the package
lists accordingly.
@bluca

bluca commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

Looks like we need to wait for the new version to migrate from stonking-proposed to stonking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants