Remove Support for legacy Password Hashers #447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #447 +/- ##
============================================
- Coverage 36.01% 35.53% -0.48%
+ Complexity 1137 1121 -16
============================================
Files 185 183 -2
Lines 4584 4547 -37
============================================
- Hits 1651 1616 -35
+ Misses 2933 2931 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0x46616c6b
force-pushed
the
remove-legacy-password-hash-support
branch
from
5cacbf5 to
e582148
Compare
|
Don't you think future migrations to newer password hashing algorithms will eventually become necessary? |
|
In future I would maybe add a new implementation but for now I would remove it, remove the complexity and reevaluate if it is necessary. We also never did another migration for quite a while now and therefor I prefer the simplicity |
|
Code changes look good to me, though I wonder what happens if installations still have old passwords in their database 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had built in a special case to cover your need to migrate old passwords to more modern hash algorithms. This is done and we can remove the special handling for old password hash algorithms.