Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Added password requirements on registration page #111

Closed
wants to merge 4 commits into from

Conversation

zyang7
Copy link

@zyang7 zyang7 commented Apr 17, 2018

Description

Added a password requirements alert if the user's selected password does not match the current password standards for the application. This functionality helps the user better select a secure password, and helps them know what is required of them unlike previous versions that would not warn them that their password was not proper.

Fixes #76

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested on localhost with valid inputs except for the password requirements. Got this output:
screen shot 2018-04-15 at 4 50 02 pm

Checklist:

  • My PR follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] Any dependent changes have been merged

Code/Quality Assurance Only

  • [x ] My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

zyang7 added 4 commits April 7, 2018 12:32
… password requirements if their password does not meet the requirements. Addresses Issue systers#76. Motivation for this fix is for the user to easily generate a password. Previously, the user had to guess what the password requirements were.
… password requirements if their password does not meet the requirements. Addresses Issue systers#76. Motivation for this fix is for the user to easily generate a password. Previously, the user had to guess what the password requirements were.
@shreyans29
Copy link

Hey @zyang7 Can you sqash all your commits into 1 commit.

@Raxerz
Copy link

Raxerz commented May 10, 2018

@Buddhiprabha the comments on this PR have not been addressed yet, it can be closed.

@Buddhiprabha
Copy link
Member

@Raxerz we can squash and merge this if the suggested changes can be approved. Please comment if they are invalid or approve otherwise.

@Raxerz
Copy link

Raxerz commented May 10, 2018

@Buddhiprabha Although it does serve the purpose of notifying the password requirements, the UI could be better. Maybe only the necessary requirements can be shown and not all of them.
For example: If the password does not contain a special character, then only the message saying "Password should contain a special character" can be shown.

@Buddhiprabha
Copy link
Member

@Raxerz got it. @zyang7 please address the comments, the PR will be closed in 2 days otherwise.

@Buddhiprabha
Copy link
Member

Closing due to inactivity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Errors need to be updated simultaneously on the bar below
4 participants