Skip to content

fix: validate len in mmap and munmap of legacy mode #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ken4647 merged 1 commit into from
Jan 22, 2026
Merged

fix: validate len in mmap and munmap of legacy mode #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions api/ruxos_posix_api/src/imp/mmap/legacy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ pub fn sys_mmap(
) -> *mut c_void {
debug!("sys_mmap <= start: {:p}, len: {}, fd: {}", start, len, fd);
syscall_body!(sys_mmap, {
if len == 0 {
return Err(LinuxError::EINVAL);
}

#[cfg(feature = "fs")]
if !start.is_null() && fd > 0 {
let ptr = start;
Expand All @@ -41,7 +45,7 @@ pub fn sys_mmap(
return Ok(ptr);
}

let layout = Layout::from_size_align(len, 8).unwrap();
let layout = Layout::from_size_align(len, 8).map_err(|_| LinuxError::EINVAL)?;

let ptr = unsafe {
let ptr = alloc(layout).cast::<c_void>();
Expand All @@ -66,10 +70,10 @@ pub fn sys_mmap(
pub fn sys_munmap(start: *mut c_void, len: ctypes::size_t) -> c_int {
debug!("sys_munmap <= start: {:p}, len: {}", start, len);
syscall_body!(sys_munmap, {
if start.is_null() {
if start.is_null() || len == 0 {
return Err(LinuxError::EINVAL);
}
let layout = Layout::from_size_align(len, 8).unwrap();
let layout = Layout::from_size_align(len, 8).map_err(|_| LinuxError::EINVAL)?;
unsafe { dealloc(start.cast(), layout) }
Ok(0)
})
Expand Down
Loading