Allow trends to be recorded as histograms instead of summaries via options argument - #20
Draft
ahinh43 wants to merge 5 commits into
Draft
Allow trends to be recorded as histograms instead of summaries via options argument#20ahinh43 wants to merge 5 commits into
ahinh43 wants to merge 5 commits into
Conversation
Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
Signed-off-by: Alec Hinh <alec.hinh@zapier.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17
This PR adds the ability to optionally record trend metrics as Prometheus Histograms instead of Summary types. This is controlled with a new option argument named
-o usehistogramfortime=yes(name suggestions are welcome 😅)This can be tested by passing the argument into the K6 binary when calling it after build:
Command:
Which then the metrics endpoint will output this example in the trend related metrics
If you don't pass
usehistogramfortime=yesthen the default summary type is still used.Command:
Output:
I've updated the README where I thought would be necessary but if there's any other places that should be updated please let me know. Thanks!