Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Auto Dark Mode #502

Closed
wants to merge 2 commits into from
Closed

Add Auto Dark Mode #502

wants to merge 2 commits into from

Conversation

jeanoskii
Copy link

Added a feature to automatically change Windows system and app themes from light to dark and vice versa, based on user defined sunset and sunrise times.

@leostudiooo
Copy link
Contributor

Seems we've got the same feature with the scripts at t1m0thyj/WDD-scripts /stable with a similar implement.

Have you tested it yet whether it has the same problem(#427) like those scripts do? Maybe only changing registry doesn't work anymore.

@jeanoskii
Copy link
Author

I wasn't aware about the scripts thing honestly. It wasn't touted as a feature in the WDD Github page, so I went ahead and implemented an Auto Dark Mode feature as part of the icon menu.

@leostudiooo
Copy link
Contributor

I've checked your code and it's the same implement as the script's (by writing the registry key), so it probably has the same issue.

@jeanoskii
Copy link
Author

I'll check if my implementation resolves #427

@t1m0thyj
Copy link
Owner

@jeanoskii Thanks for your contribution!

This feature is already implemented in the WDD-scripts repo, and I don't plan to add features unrelated to dynamic wallpaper into the core app.

For that reason I'm closing this PR, but would welcome a few other contributions:

I wasn't aware about the scripts thing honestly. It wasn't touted as a feature in the WDD Github page

  • A PR that updates the WDD GitHub page to mention scripts more prominently would be welcome.

I've checked your code and it's the same implement as the script's (by writing the registry key), so it probably has the same issue.

  • A PR that updates the ChangeWindowsAppTheme and ChangeWindowsSystemTheme scripts to fix this issue would also be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants