Merge pull request #4 from t3n/error-fix

BUGFIX: ResolveInfo::$path is already an array in graphql-php
t3n · Nov 29, 2018 · a2df4a0 · a2df4a0
2 parents 0d9444d + 941ee7f
commit a2df4a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/src/Stitching/DefaultMergedResolver.php b/src/Stitching/DefaultMergedResolver.php
@@ -29,7 +29,9 @@ public static function invoke($parent, array $args, $context, ResolveInfo $info)
 
         if ($errorResult['kind'] === 'OWN') {
             $error = Error::createLocatedError(
-                new Error($errorResult['error']->message, $info->fieldNodes, Errors::responsePathAsArray($info->path))
+                new Error($errorResult['error']->message),
+                $info->fieldNodes,
+                $info->path
             );
             throw $error;
         }

diff --git a/src/Stitching/Errors.php b/src/Stitching/Errors.php
@@ -11,7 +11,6 @@
 use function array_keys;
 use function array_map;
 use function array_merge;
-use function array_reverse;
 use function array_slice;
 use function count;
 use function implode;
@@ -127,7 +126,7 @@ public function __construct(string $message, array $errors)
             $locatedError = Error::createLocatedError(
                 $newError,
                 $info->fieldNodes,
-                static::responsePathAsArray($info->path)
+                $info->path
             );
             throw $locatedError;
         }
@@ -141,23 +140,6 @@ public function __construct(string $message, array $errors)
         return $resultObject;
     }
 
-    /**
-     * @param mixed[]|null $path
-     *
-     * @return mixed[]
-     */
-    public static function responsePathAsArray(?array $path) : array
-    {
-        $flattened = [];
-        $curr      = $path;
-        while ($curr) {
-            $flattened[] = $curr['key'];
-            $curr        = $curr['prev'];
-        }
-
-        return array_reverse($flattened);
-    }
-
     /**
      * @param Error[] $errors
      */