Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for allowing/preventing search to wrap around #897

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johnckendall
Copy link

Simple option to prevent search wraparound like the vi option: set nowrap and set wrap

@t9md
Copy link
Owner

t9md commented Oct 15, 2017

Why did you change repository reference? I can not get your intention.
Also, I think your PR have following caveat.(not confirmed, just from code-read).

  • When there is no match in forwarding direction, it return last match(it should return nothing).

Also I need test spec before merging this(this is depending on content of changes, I sometime accept test-less PR).

@johnckendall
Copy link
Author

johnckendall commented Oct 25, 2017

Sorry, new to this; first PR. I will look into creating a test spec.
About the repo reference; I thought I needed to do this to make sure I get my version locally? Still not sure how this stuff works I guess.
Regarding the last match behavior; I left it that way because I like the way it works! ;-) I suppose I could add another option switch to turn it off if you think it is needed.
(sorry for late reply, i've been on a cruise in the gulf for last 10 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants