Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.33 - Add GroupSets #1444

Merged
merged 83 commits into from
Sep 17, 2024
Merged

v0.33 - Add GroupSets #1444

merged 83 commits into from
Sep 17, 2024

Conversation

jacalata
Copy link
Contributor

@jacalata jacalata commented Aug 21, 2024

Features:

  • add name, datasource-name to Job item
  • enable bulk add and remove users
  • Linked Tasks: get, get by ID, run Now
  • implement Tags: create new, add/delete for workbooks, flows, datasources
  • get page and chunk size from env vars
  • add some repr implementations
  • implement virtual connections

Bugfix:
#1447
#1449

[email protected] and others added 30 commits June 5, 2024 20:04
Updating this list which had become quite old. Also including a simple script
for updating the list periodically. TODO: Improve the script to include the
user's name as well. (Will require using a Github token to avoid being rate
limited.)
Add workbook and datasource name attributes to JobItem Model
chore: make auth endpoint imports absolute
Add __str__() and __repr__() to DatabaseItem
Pager Protocols were missing the generic flags. Added those in
so the Pager correctly passes through the typing information.
Also removes the kwargs from the function signature of the Endpoint.get
protocol to make the Workbook endpoint match.

Adding a return annotation of `None` to the tests is very important
because it is what enables static type checkers, like mypy, to inspect
those functions. With these annotations now in place, users of TSC
should more transparently be able to carry through typing information
when using the Pager.
@jorwoods
Copy link
Contributor

Please consider #1447 and #1449 for inclusion in this release. They fix minor errors in typing that end up affecting the IDE/LSP's ability to properly detect type information.

Merge pull request #1429 from jorwoods/jorwoods/virtual_connections
@jacalata
Copy link
Contributor Author

jacalata commented Sep 2, 2024

I should have been squashing all these merges - I went back and re-did the virtual connections, I'll do the tagging change as well, and leave the others as is.

@jorwoods
Copy link
Contributor

jorwoods commented Sep 6, 2024

And one more, #1454. Without it, if a user queries permissions on an object that has a groupSet element, the call will error.

@bcantoni
Copy link
Contributor

@jacalata @jorwoods let's coordinate on 0.33. I'm working on one fix for a customer issue.

@bcantoni
Copy link
Contributor

Okay I think we have all the PRs that @jorwoods and I were waiting for included now.

jorwoods and others added 2 commits September 17, 2024 13:33
Previously we just handled monthly schedules which repeated on a day (1-31)
or 'LastDay'. Tableau Server has since added more options such as "first
Monday". This change catches up the interval validation to match what might
be received from the server.

Fixes #1358

* Add failing test for "monthly on first Monday" schedule
* Add support for all monthly schedule variations
* Unrelated fix for debug logging of API responses and add a small warning
@jacalata jacalata closed this Sep 17, 2024
@jacalata jacalata reopened this Sep 17, 2024
@jacalata jacalata merged commit 4259316 into master Sep 17, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants