-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.33 - Add GroupSets #1444
Merged
Merged
v0.33 - Add GroupSets #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating this list which had become quite old. Also including a simple script for updating the list periodically. TODO: Improve the script to include the user's name as well. (Will require using a Github token to avoid being rate limited.)
Update contributors
Add workbook and datasource name attributes to JobItem Model
chore: make auth endpoint imports absolute
chore: make imports for flows absolute
feat: group bulk edit
Add __str__() and __repr__() to DatabaseItem
feat: add support for groupsets
Pager Protocols were missing the generic flags. Added those in so the Pager correctly passes through the typing information. Also removes the kwargs from the function signature of the Endpoint.get protocol to make the Workbook endpoint match. Adding a return annotation of `None` to the tests is very important because it is what enables static type checkers, like mypy, to inspect those functions. With these annotations now in place, users of TSC should more transparently be able to carry through typing information when using the Pager.
chore: typing decorators
fix: JobItem repr
Merge pull request #1429 from jorwoods/jorwoods/virtual_connections
7d7ed11
to
fad98bd
Compare
I should have been squashing all these merges - I went back and re-did the virtual connections, I'll do the tagging change as well, and leave the others as is. |
And one more, #1454. Without it, if a user queries permissions on an object that has a groupSet element, the call will error. |
Okay I think we have all the PRs that @jorwoods and I were waiting for included now. |
Previously we just handled monthly schedules which repeated on a day (1-31) or 'LastDay'. Tableau Server has since added more options such as "first Monday". This change catches up the interval validation to match what might be received from the server. Fixes #1358 * Add failing test for "monthly on first Monday" schedule * Add support for all monthly schedule variations * Unrelated fix for debug logging of API responses and add a small warning
52c1541
to
28c2487
Compare
bcantoni
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Bugfix:
#1447
#1449