feat: make ResourceReference hashable #1668
Open
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorwoods
force-pushed
the
jorwoods/hashing_reference
branch
from
3890990 to
a7310ee
Compare
Closes tableau#1666 This allows `ResourceReference` to be used as a key in dicts, as well as added to sets by making it hashable. Also adds a `to_reference` method, while leaving the the `as_reference` static method in place untouched.
jorwoods
force-pushed
the
jorwoods/hashing_reference
branch
from
a7310ee to
c39ba83
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request adds type safety improvements and a new to_reference() method to model classes. The changes include:
- Adding type hints to
ResourceReferenceclass methods and properties - Implementing
__hash__()method forResourceReferenceto make it hashable - Adding
to_reference()instance methods toUserItem,GroupItem, andGroupSetItemthat convert instances toResourceReferenceobjects - Adding null safety checks in the permissions request factory to validate grantee IDs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tableauserverclient/models/reference_item.py | Added type hints and __hash__() method to ResourceReference class |
| tableauserverclient/models/user_item.py | Added to_reference() method with null check for converting UserItem to ResourceReference |
| tableauserverclient/models/group_item.py | Added to_reference() method with null check for converting GroupItem to ResourceReference |
| tableauserverclient/models/groupset_item.py | Added to_reference() method with null check for converting GroupSetItem to ResourceReference |
| tableauserverclient/server/request_factory.py | Added validation to ensure grantee has an ID before adding to XML element |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jorwoods
force-pushed
the
jorwoods/hashing_reference
branch
from
3ca1445 to
9e697e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1666
This allows
ResourceReferenceto be used as a key in dicts, as well as added to sets by making it hashable. Also adds ato_referencemethod, while leaving the theas_referencestatic method in place untouched.