Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enum(confgen): check enum value alias uniqueness #109

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

wenchy
Copy link
Member

@wenchy wenchy commented Jun 27, 2024

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 18 lines in your changes missing coverage. Please review.

Project coverage is 64.40%. Comparing base (fc92612) to head (28af0df).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/xproto/enum.go 63.63% 5 Missing and 3 partials ⚠️
xerrors/ecode.go 0.00% 7 Missing ⚠️
internal/xproto/value.go 50.00% 1 Missing and 1 partial ⚠️
xerrors/desc.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   64.36%   64.40%   +0.03%     
==========================================
  Files          69       68       -1     
  Lines        7566     7560       -6     
==========================================
- Hits         4870     4869       -1     
+ Misses       2125     2116       -9     
- Partials      571      575       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenchy wenchy force-pushed the check-enum-value-alias-uniqueness branch from 56be953 to 2bc249a Compare September 11, 2024 02:11
@wenchy wenchy changed the title enum: check enum value alias uniqueness when define enum type in sheet or proto file enum(confgen): check enum value alias uniqueness Sep 11, 2024
@wenchy wenchy marked this pull request as ready for review September 11, 2024 06:14
@Kybxd Kybxd merged commit 0c949cc into master Sep 11, 2024
8 checks passed
@Kybxd Kybxd deleted the check-enum-value-alias-uniqueness branch September 11, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enum(confgen): check enum value alias uniqueness
2 participants