Export Schema and Column types so they can be used externally #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Sutula <[email protected]>
Signed-off-by: Aaron Sutula <[email protected]>
|
No idea why the tests would be failing. Any ideas what's up? |
asutula
commented
Sep 27, 2023
There was a problem hiding this comment.
This is a result of just running npm install in the root of the project.
There was a problem hiding this comment.
Looks like all the updates are needed, so this works well.
Yeah, this is a known bug #40. If you see that the tests are failing with |
joewagner
approved these changes
Sep 27, 2023
|
Nice! |
|
Rerunning tests again... 🤞🏼 |
carsonfarmer
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't use the
Schematype without this.I was trying to use
type Schema = Table["schema"]and then exporting things that useSchema, but of course got a ts error that the SDK's internalSchematype can't be named, which makes sense since it wasn't exported.Figure we might as well export
Columnas well.