Expose a Local Tableland method that restarts the validator #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joewagner
commented
Oct 12, 2023
There was a problem hiding this comment.
@carsonfarmer This is the change I came up with for the fix Dimo is asking for in Discord.
If this looks good/makes sense to you, I'll publish a pre version today so they can try it out.
| @@ -165,6 +165,49 @@ class LocalTableland { | |||
| ); | |||
| } | |||
|
|
|||
| await this.#_startValidator(); | |||
There was a problem hiding this comment.
I moved the validator initialization logic into a function that can be called multiple times.
| if (this.silent as boolean) return; | ||
|
|
||
| console.log("\n\n****** Tableland is running! ******"); | ||
| console.log(" _________"); |
There was a problem hiding this comment.
The diff here looks a bit weird because I moved the validator init code without changing it. Because of that this is added and removed.
| @@ -273,6 +277,11 @@ class LocalTableland { | |||
| return await prom; | |||
| } | |||
|
|
|||
| async restartValidator(): Promise<void> { | |||
| await this.shutdownValidator(); | |||
| await this.#_startValidator(); | |||
There was a problem hiding this comment.
We already had a shutdownValidator method, just needed to add the _startValidator
joewagner
force-pushed
the
joe/enable-chainsnapshot
branch
from
c253979 to
786e4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Hardhat has an RPC API that contains methods to take a snapshot of the chain state, and then revert to a given state.
Docs are here: https://hardhat.org/hardhat-network/docs/reference#evm_snapshot
This is useful for testing contracts, but the local tableland network becomes out of sync when this happens because the tables materialized by the Validator are no longer valid.
This PR enables local tableland users who want to snapshot and revert to do so in a way that keeps the Validator up to date with the reverted chain state.
Details
The mechanism used here to re-sync the validator with the chain is to simple shutdown and restart the validator. The methods needed to accomplish that haven't been public, so this PR simply does a small refactor and exposes a new method called
restartValidator.