Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node-helpers|cli): node-helpers missing export #74

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

dtbuchholz
Copy link
Contributor

@dtbuchholz dtbuchholz commented Nov 8, 2023

Summary

The node-helpers package was exporting things from "./utils", but this should have been "./utils.js". This impacted the CLI since it uses the helpers, so no commands would work. Also includes some dependabot dep bumps; closes #56, #71, #72.

Details

Prior to the fix, you would run into this error when trying to actually use jsonFileAliases from node-helpers as well as any CLI commands:

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/dtb/tbl/tableland-js/packages/node-helpers/dist/esm/utils' imported from /Users/dtb/tbl/tableland-js/packages/node-helpers/dist/esm/index.js

The changes bump the cli to 5.3.2 and node-helpers to 0.0.2.

How it was tested

  • Built the CLI and tested the dist/cli.js commands locally.
  • Symlink in a test Node.js project to import/use jsonFileAliase from @tableland/node-helpers.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

sanderpick
sanderpick previously approved these changes Nov 8, 2023
@dtbuchholz dtbuchholz merged commit 2fcc8a0 into main Nov 8, 2023
4 checks passed
@dtbuchholz dtbuchholz deleted the dtb/fix-node-helpers-export branch November 8, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants