Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check hypothesis why CI might fail on windows #419

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anton-trunov
Copy link
Member

Closes #318

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota
Copy link
Member

novusnota commented Jun 14, 2024

By default CI on Windows is being run in pwsh, not powershell, which may be the cause of the issue. Previously the default was cmd, so we may try to explicitly set:

defaults:
  run:
    shell: cmd

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_iddefaultsrunshell

P.S.: It seems no one on the team has a Windows machine anymore :)

@anton-trunov anton-trunov marked this pull request as draft June 16, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blueprint CI check silently fails on Windows
2 participants