Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent shadowing of trait consts by contract vars #480

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix: prevent shadowing of trait consts by contract vars #480

merged 2 commits into from
Jun 25, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Jun 25, 2024 •
edited
Loading

Closes #477

  • I have updated CHANGELOG.md
  • [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pulls/PR_NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.4.1 milestone Jun 25, 2024
@anton-trunov anton-trunov self-assigned this Jun 25, 2024
@anton-trunov anton-trunov merged commit a98d4f4 into main Jun 25, 2024
3 checks passed
@anton-trunov anton-trunov deleted the fix-contract-var-and-trait-const-name-clashes branch June 25, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

Typechecker misses name clashes between contract vars and consts inhereted from a trait
1 participant
@anton-trunov