Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grammar): Error messages for non-abstract constants #483

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

byakuren-hijiri
Copy link
Contributor

@byakuren-hijiri byakuren-hijiri commented Jun 26, 2024

Closes #332

  • I have updated CHANGELOG.md
  • [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pulls/PR_NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

anton-trunov
anton-trunov previously approved these changes Jun 26, 2024
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@anton-trunov anton-trunov added this to the v1.4.1 milestone Jun 26, 2024
@anton-trunov anton-trunov self-assigned this Jun 26, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@anton-trunov anton-trunov merged commit 779b0fe into tact-lang:main Jun 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message for non-initialized contract constants
2 participants