Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add traversing of init AST when filling dependsOn for initOf calls #521

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Add traversing of init AST when filling dependsOn for initOf calls #521

merged 5 commits into from
Jul 3, 2024
+134 −0

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Jul 2, 2024 •
edited
Loading

Closes #511

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.4.1 milestone Jul 2, 2024
anton-trunov
anton-trunov requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's resolve the merge conflicts and we are good to go

@Gusarich Gusarich mentioned this pull request Jul 2, 2024
Closed
@anton-trunov anton-trunov self-assigned this Jul 3, 2024
@anton-trunov anton-trunov merged commit c9e383a into tact-lang:main Jul 3, 2024
3 checks passed
@Gusarich Gusarich mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

Strange behavior of initOf in contract init
2 participants
@Gusarich @anton-trunov