Skip to content

Commit

Permalink
Fix branch name in deployment workflow
Browse files Browse the repository at this point in the history
- `$default-branch` is for workflow templates, not actual workflows
  • Loading branch information
taesungh committed Nov 17, 2024
1 parent fa8fb12 commit 9a98dc5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Deploy site to GitHub Pages

on:
push:
branches: [$default-branch]
branches: [main]

# Include permissions for GITHUB_TOKEN to deploy to GitHub Pages
permissions:
Expand Down
10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"type": "module",
"scripts": {
"dev": "vite",
"test": "jest --watch",
"build": "tsc -b && vite build",
"test": "vitest --watch",
"build": "tsc -b && vite build --base=/pheatures/",
"lint": "eslint .",
"preview": "vite preview"
"preview": "vite preview --base=/pheatures/"
},
"dependencies": {
"@emotion/react": "^11.9.0",
Expand All @@ -33,10 +33,10 @@
"eslint-plugin-react-hooks": "^5.0.0",
"eslint-plugin-react-refresh": "^0.4.13",
"globals": "^15.11.0",
"jest": "^28.1.0",
"ts-jest": "^28.0.2",
"typescript": "~5.6.2",
"typescript-eslint": "^8.10.0",
"vite": "^5.4.9"
"vite": "^5.4.9",
"vitest": "^2.1.4"
}
}
1 change: 0 additions & 1 deletion vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import react from "@vitejs/plugin-react-swc";

// https://vite.dev/config/
export default defineConfig({
base: "/pheatures/", // for deployment on GitHub pages
plugins: [react()],
resolve: {
alias: {
Expand Down

0 comments on commit 9a98dc5

Please sign in to comment.