Skip to content

Update nesting level data type from u16 to u32 to avoid attempt to add with overflow panic #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gliderkite wants to merge 1 commit into from
+5 −5
Closed

Update nesting level data type from u16 to u32 to avoid attempt to add with overflow panic #934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/name.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ struct NamespaceBinding {
/// Level of nesting at which this namespace was declared. The declaring element is included,
/// i.e., a declaration on the document root has `level = 1`.
/// This is used to pop the namespace when the element gets closed.
level: u16,
level: u32,
}

impl NamespaceBinding {
Expand Down Expand Up @@ -489,7 +489,7 @@ pub struct NamespaceResolver {
bindings: Vec<NamespaceBinding>,
/// The number of open tags at the moment. We need to keep track of this to know which namespace
/// declarations to remove when we encounter an `End` event.
nesting_level: u16,
nesting_level: u32,
}

/// That constant define the one of [reserved namespaces] for the xml standard.
Expand Down Expand Up @@ -993,7 +993,7 @@ impl NamespaceResolver {
/// ```
///
/// [current]: Self::level
pub const fn bindings_of(&self, level: u16) -> NamespaceBindingsOfLevelIter<'_> {
pub const fn bindings_of(&self, level: u32) -> NamespaceBindingsOfLevelIter<'_> {
NamespaceBindingsOfLevelIter {
resolver: self,
cursor: 0,
Expand Down Expand Up @@ -1030,7 +1030,7 @@ impl NamespaceResolver {
///
/// [`push`]: Self::push
/// [`pop`]: Self::pop
pub const fn level(&self) -> u16 {
pub const fn level(&self) -> u32 {
self.nesting_level
}
}
Expand Down Expand Up @@ -1092,7 +1092,7 @@ pub type PrefixIter<'a> = NamespaceBindingsIter<'a>;
pub struct NamespaceBindingsOfLevelIter<'a> {
resolver: &'a NamespaceResolver,
cursor: usize,
level: u16,
level: u32,
}

impl<'a> Iterator for NamespaceBindingsOfLevelIter<'a> {
Expand Down