Remove mention of escape sequences from several unapplicable places#937
Merged
Mingun merged 1 commit intotafia:masterfrom Feb 15, 2026
Merged
Remove mention of escape sequences from several unapplicable places#937Mingun merged 1 commit intotafia:masterfrom
Mingun merged 1 commit intotafia:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #937 +/- ##
==========================================
- Coverage 58.08% 54.99% -3.09%
==========================================
Files 42 44 +2
Lines 15513 16817 +1304
==========================================
+ Hits 9011 9249 +238
- Misses 6502 7568 +1066
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dralley
requested changes
Feb 15, 2026
src/events/mod.rs
Outdated
| /// | ||
| /// This will allocate if the value contains any escape sequences or in | ||
| /// non-UTF-8 encoding. | ||
| /// This will allocate if the value in non-UTF-8 encoding. |
Collaborator
There was a problem hiding this comment.
This will allocate if the value is encoded in a non-UTF-8 encoding
(and repeat below)
Collaborator
Author
There was a problem hiding this comment.
Thanks! All mentioned problems fixed
Mingun
force-pushed
the
clarify-events-content
branch
from
30594bc to
1f6a92c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies some unclear documentation about escape rules in
BytesText. Currently it is expected that you may to create event from string with forbidden characters, but they will be escaped.Fixes #915