Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address feature/issue #1038 #1039

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

kevincw01
Copy link

adds pump/config subscription in mqttinterface.ts to allow changes to the RPM similar to the put API.

@tagyoureit
Copy link
Owner

You can't hardcode circuits[0]. This won't work for everyone. The entire pump config needs to be passed.

The preferred approach is to have multiple circuits for different speeds, not change the speed of a single circuit.
image

@kevincw01
Copy link
Author

makes sense. I'll put a loop on all circuits in there.

@kevincw01
Copy link
Author

@tagyoureit ok all fixed.

@tagyoureit
Copy link
Owner

You don't want to loop through all the circuits and set each one async. If you have multiple pump circuits to send, follow the pattern in /config/pump that sets all of the pump circuits at once. If you watch the javascript console when changing these (see pic when you click on the pump in the pump section), you'll see the body is formatted like:

{"id":1,"circuits":[{"speed":2150,"units":{"val":0},"id":1,"circuit":132},{"speed":3450,"units":{"val":0},"id":2,"circuit":133},{"speed":1800,"units":{"val":0},"id":3,"circuit":244},{"speed":2100,"units":{"val":0},"id":4,"circuit":129},{"speed":3450,"units":{"val":0},"id":5,"circuit":130},{"speed":3450,"units":{"val":0},"id":6,"circuit":135},{"speed":1100,"units":{"val":0},"id":7,"circuit":6}]}

id is the pump id. And the speeds for the circuits are passed as an object.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants