Merged
Conversation
Contributor
Author
|
Oh, I hadn't realise it would fail if you used a non-nightly with that flag. Is there a way to check if the current version of |
Owner
I think you can check rustc version like: Lines 205 to 211 in 550dc19 |
Owner
|
The actual error here is due to the version of llvm-cov command (-show-mcdc requires LLVM 18+), so a check like |
taiki-e
approved these changes
Jul 18, 2024
Owner
|
Published in 0.6.11. Thanks @aytey! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MC/DC coverage recently landed in
rustc:but
cargo-llvm-covdoesn't yet pass the-show-mcdcflag tollvm-cov, so we cannot get reports showing MC/DC coverage.This PR adds support for
-show-mcdctollvm-covwhen working withcargo-llvm-cov.I checked: if
RUSTFLAGScontains-Zcoverage-options=branch(i.e., MC/DC is not enabled) then the reports are the same as if you didn't pass-show-mcdc(i.e., you don't get "empty" MC/DC tables).