Support runner-run - #1901
Open
kjanat wants to merge 4 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
CARGO_MANIFEST_DIR is backslash-separated on Windows, so strip_suffix("tools/codegen") never matched and panicked. Walk ancestors().nth(2) instead, which is separator-agnostic.
Add base + generated manifest for runner-run (https://github.com/kjanat/runner). Regenerating TOOLS.md also corrects a pre-existing stale convco install-location entry.
Validate installed binaries by their resolved install paths when available so Windows bash environments do not pick up shadowing system commands such as Cygwin's run.exe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Note: runner-run 0.12.2 is present as an exact version; latest remains on 0.12.1 due the manifest generator's 24-hour cooldown for new releases.