Allow #[project] to be used on if let expressions#181
Merged
bors[bot] merged 6 commits intotaiki-e:masterfrom Mar 20, 2020
Merged
Allow #[project] to be used on if let expressions#181bors[bot] merged 6 commits intotaiki-e:masterfrom
#[project] to be used on if let expressions#181bors[bot] merged 6 commits intotaiki-e:masterfrom
Conversation
taiki-e
added
C-enhancement
5 tasks
This PR would work correctly, except for the fact that rust-lang/rust#68618 causes a compilation error to be emitted before we even have a chance to run. That issue is independent of the implementation of this PR, so this PR should start working automatically once the issue is resolved.
Aaron1011
force-pushed
the
feature/project-if-let
branch
from
8920b02 to
f626aa8
Compare
Aaron1011
changed the title
#[project] to be used on if let expressions#[project] to be used on if let expressions
Collaborator
Author
|
@taiki-e: This is ready for review. It will start compiling tomorrow, when rust-lang/rust#69201 becomes part of the next nightly. The output of |
Aaron1011
force-pushed
the
feature/project-if-let
branch
from
8998a80 to
9910909
Compare
Collaborator
Author
|
All tests are now passing with the latest nightly. |
Collaborator
Author
|
@taiki-e: Are there any changes that you'd like me to make? |
Owner
|
Looks great, thank you! bors r+ |
Contributor
bors bot
added a commit
to taiki-e/auto_enums
that referenced
this pull request
Apr 14, 2020
89: Add tests for `#[attr] if` r=taiki-e a=taiki-e Closes #86 Refs: taiki-e/pin-project#181 Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
added
the
A-project-attribute
taiki-e
removed
the
C-enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would work correctly, except for the fact that
rust-lang/rust#68618 causes a compilation error to be emitted before we
even have a chance to run. That issue is independent of the
implementation of this PR, so this PR should start working automatically
once the issue is resolved.