Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Keszey Dániel authored and Keszey Dániel committed May 8, 2024
1 parent b36902d commit 6e73966
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion packages/protocol/contracts/tokenvault/BridgedERC1155.sol
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ contract BridgedERC1155 is EssentialContract, ERC1155Upgradeable {

error BTOKEN_INVALID_PARAMS();
error BTOKEN_INVALID_TO_ADDR();
error BTOKEN_INVALID_BURN();

/// @notice Initializes the contract.
/// @param _owner The owner of this contract. msg.sender will be used if this value is zero.
Expand Down
2 changes: 1 addition & 1 deletion packages/protocol/test/tokenvault/ERC1155Vault.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ contract ERC1155VaultTest is TaikoTest {
uint256[] memory randomIdAndLength = new uint256[](1);
randomIdAndLength[0] = 20;
vm.prank(address(destChainErc1155Vault), address(destChainErc1155Vault));
vm.expectRevert(BridgedERC1155.BTOKEN_INVALID_BURN.selector);
vm.expectRevert("ERC1155: burn amount exceeds balance");
BridgedERC1155(deployedContract).burnBatch(randomIdAndLength, randomIdAndLength);

// After setApprovalForAll() ERC1155Vault can transfer and burn
Expand Down

0 comments on commit 6e73966

Please sign in to comment.