feat: changes based on comments

taikoxyz · Nov 5, 2024 · f6860b5 · f6860b5
1 parent 479711d
commit f6860b5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/taiko-client/driver/chain_syncer/blob/syncer.go b/packages/taiko-client/driver/chain_syncer/blob/syncer.go
@@ -49,7 +49,7 @@ type Syncer struct {
 	reorgDetectedFlag   bool
 	maxRetrieveExponent uint64
 	blobDatasource      *rpc.BlobDataSource
-	mutex               *sync.Mutex
+	mutex               sync.Mutex
 }
 
 // NewSyncer creates a new syncer instance.
@@ -90,7 +90,6 @@ func NewSyncer(
 			blobServerEndpoint,
 			socialScanEndpoint,
 		),
-		mutex: new(sync.Mutex),
 	}, nil
 }
 

diff --git a/packages/taiko-client/driver/driver_test.go b/packages/taiko-client/driver/driver_test.go
@@ -592,7 +592,7 @@ func (s *DriverTestSuite) insertSoftBlock(
 		marker = softblocks.BatchMarkerEmpty
 	}
 
-	txBatch := softblocks.TransactionBatch{
+	txBatch := &softblocks.TransactionBatch{
 		BlockID:          l2BlockID,
 		ID:               batchID,
 		TransactionsList: b,

diff --git a/packages/taiko-client/driver/soft_blocks/api.go b/packages/taiko-client/driver/soft_blocks/api.go
@@ -77,7 +77,7 @@ func (b *TransactionBatch) ValidateSignature() (bool, error) {
 // soft blocks creation requests.
 type BuildSoftBlockRequestBody struct {
 	// @param transactionBatch TransactionBatch Transaction batch to be inserted into the soft block
-	TransactionBatch TransactionBatch `json:"transactionBatch"`
+	TransactionBatch *TransactionBatch `json:"transactionBatch"`
 }
 
 // CreateOrUpdateBlocksFromBatchResponseBody represents a response body when handling soft
@@ -109,6 +109,9 @@ func (s *SoftBlockAPIServer) BuildSoftBlock(c echo.Context) error {
 	if err := c.Bind(reqBody); err != nil {
 		s.returnError(c, http.StatusUnprocessableEntity, err)
 	}
+	if reqBody.TransactionBatch == nil {
+		return s.returnError(c, http.StatusBadRequest, errors.New("transactionBatch is required"))
+	}
 
 	log.Info(
 		"New soft block building request",