Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge): add ttko to dropdown #14244

Closed
wants to merge 4 commits into from
Closed

feat(bridge): add ttko to dropdown #14244

wants to merge 4 commits into from

Conversation

2manslkh
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #14244 (671fc1d) into main (d5ca9c1) will increase coverage by 43.37%.
Report is 66 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main   #14244       +/-   ##
===========================================
+ Coverage   50.89%   94.26%   +43.37%     
===========================================
  Files         153       38      -115     
  Lines        3973      872     -3101     
  Branches      336      112      -224     
===========================================
- Hits         2022      822     -1200     
+ Misses       1840       50     -1790     
+ Partials      111        0      -111     
Flag Coverage Δ
bridge-ui 94.26% <100.00%> (ø)
eventindexer ?
protocol ?
relayer ?
ui ?
Files Changed Coverage Δ
packages/bridge-ui/src/token/tokens.ts 100.00% <100.00%> (ø)

... and 115 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dionysuzx
Copy link
Collaborator

@2manslkh @jscriptcoder any updates on this?

@2manslkh
Copy link
Contributor Author

2manslkh commented Aug 1, 2023

@d1onys1us seems like there is a PR for it for bridge ui v2

@dionysuzx
Copy link
Collaborator

@d1onys1us seems like there is a PR for it for bridge ui v2

is there any harm in adding this @jscriptcoder? or do you suggest we close it?

@jscriptcoder
Copy link
Contributor

I'd say we can add it to the current bridge

@cyberhorsey
Copy link
Contributor

This will add TTKO and not TTKOe, and be hardcoded for both bridges. It's better to add it as an environment variable.

@dionysuzx dionysuzx deleted the bridge-improvements branch August 23, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TTKO to the bridge app in the dropdown
5 participants