Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): optimize core protocol and bridge implementation #14310

Merged
merged 148 commits into from
Aug 27, 2023
Merged

refactor(protocol): optimize core protocol and bridge implementation #14310

merged 148 commits into from
Aug 27, 2023

Conversation

adaki2004
Copy link
Contributor

@adaki2004 adaki2004 commented Jul 28, 2023 •
edited by dantaik
Loading

Inspired by Brecht's feature request, this PR aims to separate the current prover (pool) contract from the core protocol, allowing various prover contract designs. Taiko will act as the "glue" between the core protocol and different prover contracts.

Core protocol Changes introduced in this PR:

  • Block Proposal: Blocks must assign a non-zero prover address, and proposers will pay a non-refundable Ether fee to the prover. The prover will burn Taiko tokens as a bond, returned if proof is submitted within 90 minutes; otherwise, the block opens, and half the bond goes to the actual prover.
  • Prover Authorization: If an EOA, must authorize the proposer with a valid ECDSA signature; if a contract, must have a onBlockAssigned function that doesn't revert.
  • Notification Calls: Removed on-chain notification calls to prover (pool) contract to prevent malicious exploitation.
  • Prover (Pool) Contract and API: Deleted IProverPool. Taiko and partners will create a Pool API server for proposers to access proving services.
  • Token and Configuration: Taiko token supply won't increase; decimals are set to 18. TaikoConfig is simplified, loaded from a Library for testing.
  • @davidtaikocha @smtmfft I added two TODOs for you in this PR.

Taiko Token functions as a bond token for provers.

Bridge changes introduced in this PR:

  • Introduced a recallMessage on the source bridge, it will call the message.from to perform custom recall function. (Releasing Ether is no longer handled by the bridge, but the message's from contract.
  • Implemented all optimizations captured in this issue: A few Bridge improvement ideas #14384
  • Added NFT vaults

dantaik and others added 30 commits June 28, 2023 15:30
@dantaik @adaki2004
@dionysuzx @cyberhorsey @jscriptcoder @davidtaikocha @2manslkh @mfinestone @whohideonbug @Megumiiiiii @Venoox @github-actions @dong77 @Brechtpd
feat(protocol): alpha-4 with staking-based tokenomics (#13981)
d96e4bd 
Co-authored-by: D <[email protected]>
Co-authored-by: dantaik <[email protected]>
Co-authored-by: dave | d1onys1us <[email protected]>
Co-authored-by: adaki2004 <[email protected]>
Co-authored-by: jeff <[email protected]>
Co-authored-by: Francisco Ramos <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Kenk <[email protected]>
Co-authored-by: mfinestone <[email protected]>
Co-authored-by: hideonbug <[email protected]>
Co-authored-by: megumii <[email protected]>
Co-authored-by: Tomaž <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Wang <[email protected]>
Co-authored-by: adaki2004 <[email protected]>
Co-authored-by: Jeffery Walsh <[email protected]>
Co-authored-by: cyberhorsey <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
@dantaik
refactor(protocol): add very minor update (#14066)
c7fee73
@dantaik @cyberhorsey
refactor(protocol): optimize ProverPool (#14069)
4cb7367 
Co-authored-by: dantaik <[email protected]>
Co-authored-by: Jeffery Walsh <[email protected]>
Co-authored-by: cyberhorsey <[email protected]>
@dantaik
Merge branch 'main' into alpha-4
dc2e975
@cyberhorsey
fix(protocol): Fix alpha-4 ability to build protocol and run tests (#…
46c0e66 
…14075)
@cyberhorsey
feat(eventindexer): Alpha 4 event indexing (#14078)
dee55c9
@cyberhorsey
feat(relayer): Alpha 4 event sub (#14081)
5c40c12
@davidtaikocha
Merge branch 'main' into alpha-4
81176e3
@dantaik
chore(protocol): delete ProverPool2 and deprecated documents (#14082)
8e398f4
@cyberhorsey
feat(protocol): allow premint of TKO to multiple addresses/amounts in…
478ba5e 
… deployonl1 script (#14084)
@dantaik
chore(protocol): use block.prevrandao to avoid warning (#14088)
8ba71a6
@dantaik
Merge branch 'main' into alpha-4
6805a11
@dong77
Update TokenVault.sol
e8ffbb8
@dantaik
fix typo
2fa83d2
@dantaik
feat(protocol): restrict prover staking changes to once per hour (#14093
a539646 
)
@dantaik
feat(protocol): disable oracle proofs to be over written by regular p…
5bf313e 
…roofs (#14097)
@dantaik @dong77
feat(protocol): unify taiko tokens acros L1, L2s, and L3s (#14083)
38d537b 
Co-authored-by: dantaik <[email protected]>
Co-authored-by: Daniel Wang <[email protected]>
@cyberhorsey
Merge branch 'main' into alpha-4
4e8e78a
@cyberhorsey
feat(protocol): A4 bindings (#14101)
7f41353
@cyberhorsey
fix(eventindexer): add address to Slashed event in db, + add logs (#1…
4ef8d0c 
…4103)
@dantaik @dong77 @cyberhorsey
fix(protocol): limit reward per gas in weight calculation (#14098)
05da0e7 
Co-authored-by: Daniel Wang <[email protected]>
Co-authored-by: jeff <[email protected]>
@cyberhorsey
add provers route
c341f0a
@cyberhorsey
Merge branch 'main' into alpha-4
44d119e
@cyberhorsey
abigen
a24f9a6
@cyberhorsey
Merge branch 'alpha-4' of github.com:taikoxyz/taiko-mono into alpha-4
76d9375
@dantaik
chore(protocol) use uint32 for gas limit, gas used, gas price (#14112)
5cd6c82
@dantaik @dong77
feat(protocol): add prover into block events (#14123)
fd07f3f 
Co-authored-by: Daniel Wang <[email protected]>
@dantaik @dong77
feat(protocol): also add rewardPerGas into BlockProposedEvent (#14124)
c4c671e 
Co-authored-by: Daniel Wang <[email protected]>
@cyberhorsey
Resolve merge from main with eventindexer changes
053e198
@cyberhorsey
Merge branch 'alpha-4' of github.com:taikoxyz/taiko-mono into alpha-4
c4ab00d
dantaik
dantaik previously approved these changes Aug 26, 2023
View reviewed changes
Brechtpd
Brechtpd previously approved these changes Aug 26, 2023
View reviewed changes
@dantaik @adaki2004
@davidtaikocha @cyberhorsey
feat(protocol): simplify protocol and remove prover pool from core pr…
001b722 
…otocol (#14541)

Co-authored-by: adaki2004 <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: Jeffery Walsh <[email protected]>
Co-authored-by: D <[email protected]>
@dantaik dantaik dismissed stale reviews from Brechtpd and themself via 001b722 August 27, 2023 13:51
@dantaik dantaik changed the title refactor(protocol): optimize bridge with recallMessage and other simplifications refactor(protocol): optimize core protocol and bridge implementation Aug 27, 2023
@dantaik
Copy link
Contributor

dantaik commented Aug 27, 2023

@Brechtpd @davidtaikocha @cyberhorsey please approve this PR again -- I just merge the core protocol optimization PR into this one.

@dantaik dantaik enabled auto-merge August 27, 2023 13:54
@dantaik dantaik added this pull request to the merge queue Aug 27, 2023
Merged via the queue into main with commit 437763a Aug 27, 2023
8 of 9 checks passed
@dantaik dantaik deleted the one_txn_token_and_eth_release branch August 27, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantaik dantaik dantaik approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

Assignees

@adaki2004 adaki2004

@dantaik dantaik

Labels
area.protocol category.enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A few Bridge improvement ideas
9 participants
@adaki2004 @dantaik @Brechtpd @davidtaikocha @cyberhorsey @dong77 @dionysuzx @jscriptcoder @KorbinianK