Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): Add prover param #15758

Closed
wants to merge 1 commit into from
Closed

Conversation

Brechtpd
Copy link
Contributor

@Brechtpd Brechtpd commented Feb 13, 2024

4 tests are still failing.

Also with the contesting and stuff, it's not as clear cut when to use msg.sender and the supplied prover... So this might be a more confusing feature than I first thought because there will need to be clear rules when which is used. So not so convinced anymore we should add this.

@dantaik
Copy link
Contributor

dantaik commented Feb 13, 2024

4 tests are still failing.

Also with the contesting and stuff, it's not as clear cut when to use msg.sender and the supplied prover... So this might be a more confusing feature than I first thought because there will need to be clear rules when which is used. So not so convinced anymore we should add this.

4 tests are still failing.

Also with the contesting and stuff, it's not as clear cut when to use msg.sender and the supplied prover... So this might be a more confusing feature than I first thought because there will need to be clear rules when which is used. So not so convinced anymore we should add this.

Lets now do it for now, brecht. I think the issue you raised in the other PR about 'message.owner == msg.sender' in vaults is more critical. Do you want to fix it?

@Brechtpd
Copy link
Contributor Author

Yeah agreed we can leave it for now.

I think the issue you raised in the other PR about 'message.owner == msg.sender' in vaults is more critical. Do you want to fix it?

Yeah will look into fixing that.

@Brechtpd
Copy link
Contributor Author

Closing for now because not that important and pretty tricky.

@Brechtpd Brechtpd closed this Feb 13, 2024
@dantaik dantaik deleted the prover-param branch March 1, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants