Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bridge-ui): update to protocol 1.0, two step bridging #16230

Merged
merged 88 commits into from
Mar 22, 2024
Merged

feat(bridge-ui): update to protocol 1.0, two step bridging #16230

merged 88 commits into from
Mar 22, 2024

Conversation

KorbinianK
Copy link
Contributor

@KorbinianK KorbinianK commented Mar 1, 2024 •
edited
Loading

  • Supports protocol 1.0 changes
  • Adds two step claim dialogs for NFT, ERC20 etc.
  • Improve code coverage
  • Small bugfixes

@KorbinianK KorbinianK self-assigned this Mar 1, 2024
@KorbinianK KorbinianK marked this pull request as ready for review March 21, 2024 15:55
@openzeppelin-code OpenZeppelin Code
Copy link

feat(bridge-ui)!: update to protocol 1.0, two step bridging

Generated at commit: 3c1e6abe84fea10ed2d99cdaf5edd52f6db7a9cc

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
4
42
50
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

adaki2004
adaki2004 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@adaki2004 adaki2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty huge PR - would just rather accept it, then after deployment check via QA if we have any issues.

@KorbinianK
Copy link
Contributor Author

@adaki2004 yes, could have split it up to be honest

@KorbinianK KorbinianK added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit 71babae Mar 22, 2024
8 checks passed
@KorbinianK KorbinianK deleted the feat/bridge-ui--update-to-new-protocol branch March 22, 2024 12:51
@taiko-kitty taiko-kitty mentioned this pull request Mar 14, 2024
Merged
@taiko-kitty taiko-kitty mentioned this pull request Apr 4, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 24, 2024
Closed
@dantaik dantaik changed the title feat(bridge-ui)!: update to protocol 1.0, two step bridging feat(bridge-ui): update to protocol 1.0, two step bridging Apr 24, 2024
This was referenced Apr 24, 2024
Merged
Closed
Closed
This was referenced May 10, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d1onys1us d1onys1us d1onys1us approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@xiaodino xiaodino Awaiting requested review from xiaodino

@dantaik dantaik Awaiting requested review from dantaik

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@bearni95 bearni95 Awaiting requested review from bearni95

@bennettyong bennettyong Awaiting requested review from bennettyong

Assignees

@KorbinianK KorbinianK

Labels
area.bridge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KorbinianK @d1onys1us @adaki2004