Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): add blob-catcher to monorepo #16353

Merged
merged 21 commits into from
Mar 14, 2024
Merged

chore(repo): add blob-catcher to monorepo #16353

merged 21 commits into from
Mar 14, 2024

Conversation

dionysuzx
Copy link
Collaborator

summary

  • add blob-catcher to monorepo
  • add steps to adding a repo to monorepo to CONTRIBUTING.md

@dantaik
Copy link
Contributor

dantaik commented Mar 8, 2024

@adaki2004 We need README.md to start with...

packages/blob-storage/internal/logic/config.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/config.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/config.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/config.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/indexer/indexer_factory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mask-pp mask-pp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d1onys1us Need more test cases.

packages/blob-storage/internal/logic/callbacks.go Outdated Show resolved Hide resolved
@adaki2004
Copy link
Contributor

@adaki2004 We need README.md to start with...

Isn't it good, or what kind of readme.md you want to see ?
https://github.com/taikoxyz/taiko-mono/blob/4bde8d59e01b7a99eda6c26c850e6d34f5d58fde/packages/blob-storage/README.md

@cyberhorsey
Copy link
Contributor

I was requested to review this but don't know what I'm reviewing. @d1onys1us any context? It prints blobs out from blocks? who wrote it originally

packages/blob-storage/internal/indexer/indexer.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/indexer/indexer.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/indexer/indexer.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/indexer/indexer.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/indexer/indexer.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/callbacks.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/callbacks.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/callbacks.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/callbacks.go Outdated Show resolved Hide resolved
packages/blob-storage/internal/logic/config.go Outdated Show resolved Hide resolved
@adaki2004
Copy link
Contributor

I was requested to review this but don't know what I'm reviewing. @d1onys1us any context? It prints blobs out from blocks? who wrote it originally

Hey @cyberhorsey @mask-pp !

This subfolder includes 2 executables - i was doing it previously - a "blob-catcher" and a "server".

Blob-catcher does nothing else but listening on BlockProposed events, and if it sees a blob is used (blobUsed) inside , then it will get the blobHash, queries lighhouse for sidecar (blobs) with blockId and constructs the blobHash from the commitment, and compares it. If it matches, it stores it into DB (MongoDB). This way we are sure we store Taiko related blobs in our DB.

Server on the other hands just tries to retrieve the blob based on blobHash(es).

This is an MvP/PoC, it works but if it does not fit into the styling, maybe it is the best if you guys do the finishing touches (logs / command line arguments, etc.) because most probably it would take me much more time. I guess it is not the highest prio (for anyone) since it is proven to be working - if config vars set correctly, currently the even hash is wron, because it has changed lately - but it is definitely working. (via the readme there is a small howto).

Please help me get this into shape, where it fits with the current go code, as i know you are the go-masters here.

@cyberhorsey cyberhorsey added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit ecbf797 Mar 14, 2024
9 checks passed
@cyberhorsey cyberhorsey deleted the add-blob-storage branch March 14, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants