-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): add blob-catcher to monorepo #16353
Conversation
@adaki2004 We need README.md to start with... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d1onys1us Need more test cases.
Isn't it good, or what kind of readme.md you want to see ? |
I was requested to review this but don't know what I'm reviewing. @d1onys1us any context? It prints blobs out from blocks? who wrote it originally |
Hey @cyberhorsey @mask-pp ! This subfolder includes 2 executables - i was doing it previously - a Blob-catcher does nothing else but listening on BlockProposed events, and if it sees a blob is used ( Server on the other hands just tries to retrieve the blob based on This is an MvP/PoC, it works but if it does not fit into the styling, maybe it is the best if you guys do the finishing touches (logs / command line arguments, etc.) because most probably it would take me much more time. I guess it is not the highest prio (for anyone) since it is proven to be working - if config vars set correctly, currently the even hash is wron, because it has changed lately - but it is definitely working. (via the readme there is a small howto). Please help me get this into shape, where it fits with the current go code, as i know you are the go-masters here. |
summary