Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(repo): fix all typos #16489

Merged
merged 12 commits into from
Mar 25, 2024
Merged

docs(repo): fix all typos #16489

merged 12 commits into from
Mar 25, 2024

Conversation

momodaka
Copy link
Contributor

Description

use typos to fix all typos issue

Related issues

#16488

@momodaka momodaka changed the title doc(repo): Fix all typos (#16488) docs(repo): fix all typos Mar 20, 2024
@dantaik dantaik requested a review from adaki2004 March 21, 2024 08:01
@dantaik
Copy link
Contributor

dantaik commented Mar 21, 2024

@momodaka could you resolve the conflicts first

@momodaka
Copy link
Contributor Author

@momodaka could you resolve the conflicts first

👌, conflicts resolved

@dantaik
Copy link
Contributor

dantaik commented Mar 21, 2024

@d1onys1us do you think it's OK for this PR to modify files in more than one package?

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.62%. Comparing base (f53766b) to head (8702b26).
Report is 196 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16489      +/-   ##
==========================================
+ Coverage   26.82%   31.62%   +4.79%     
==========================================
  Files         105       65      -40     
  Lines        6188     2846    -3342     
==========================================
- Hits         1660      900     -760     
+ Misses       4348     1846    -2502     
+ Partials      180      100      -80     
Flag Coverage Δ
blobstorage 28.26% <ø> (?)
eventindexer ?
guardian-prover-health-check 35.29% <ø> (+0.48%) ⬆️
relayer 30.73% <ø> (-7.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Mar 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 5:49am

@dionysuzx
Copy link
Collaborator

@d1onys1us do you think it's OK for this PR to modify files in more than one package?

yes because repo is wide enough in scope to consume all these changes. so it's not confusing to see this in the changelog for each affected subpackage.

@dionysuzx dionysuzx added this pull request to the merge queue Mar 25, 2024
Merged via the queue into taikoxyz:main with commit 4cc2393 Mar 25, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants