Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix bridge bug caused by incorrect check of receivedAt (by OZ) #16545

Merged
merged 20 commits into from
Mar 28, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Mar 28, 2024

No description provided.

@dantaik dantaik marked this pull request as ready for review March 28, 2024 07:11
packages/protocol/contracts/bridge/Bridge.sol Dismissed Show dismissed Hide dismissed
packages/protocol/contracts/bridge/Bridge.sol Dismissed Show dismissed Hide dismissed
Copy link

openzeppelin-code bot commented Mar 28, 2024

fix(protocol): fix bridge bug caused by incorrect check of receivedAt (by OZ)

Generated at commit: a11a78048f73d8d956a462dcaaa926b5223872b1

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
41
48
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Base automatically changed from apply-private-changes to main March 28, 2024 12:25
Copy link
Contributor

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because I think the code is correct, but as I said elsewhere I think more checks than really required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants