fix(protocol): scale up basefee by GAS_TARGET * ADJUSTMENT_QUOTIENT
#16549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
commented
Mar 28, 2024
| / LibFixedPointMath.SCALING_FACTOR, | ||
| _adjustmentFactor: adjustmentFactor | ||
| }) | ||
| baseFee, 57_896_044_586_242_203_305_830_093_650_308_530_112_287_501_933_378_291_142_596 |
There was a problem hiding this comment.
57_896_044_586_242_203_305_830_093_650_308_530_112_287_501_933_378_291_142_596 is 1200000000x of 48_246_703_821_869_050_543_408_253_349_256_099_602_613_005_189_120
fix(protocol): scale up basefee by
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
2 2 0 3 41 48 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a guru on math, this PR simply tris to follow OZ's suggestion to scale up the basefee by
GAS_TARGET * ADJUSTMENT_QUOTIENT.Based on the test result in test_eip1559_math, the basefee is scaled by 1200000000 times, since in our testnet, we see basefee is almost always 1wei (maybe even much smaller than 1wei), with 1200000000x scaled up, 1200000000wei is 1.2 gwei, seems to be a reasonable number.
@Brechtpd you may have the best knowledge to make the call.