Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protocol): calculate what gasExcess value will push basefee to 1gwei then 10gwei #16550

Merged
merged 25 commits into from
Mar 29, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Mar 28, 2024

In the modified test, you'll see if we sell 327 * (gasTarget = 60_000_000) gas, then the basefee will be pushed to 1gwei. This means the current math works.

@dantaik dantaik marked this pull request as ready for review March 28, 2024 10:09
@dantaik dantaik changed the title test(protocol): calculate in a test what gasExcess will push the basefee to 1gwei test(protocol): calculate in a test what gasExcess value will push the basefee to 1gwei Mar 28, 2024
Base automatically changed from apply-private-changes to main March 28, 2024 12:25
@dantaik dantaik changed the title test(protocol): calculate in a test what gasExcess value will push the basefee to 1gwei test(protocol): calculate what gasExcess value will push basefee to 1gwei then 10gwei Mar 28, 2024
Copy link

openzeppelin-code bot commented Mar 28, 2024

test(protocol): calculate what gasExcess value will push basefee to 1gwei then 10gwei

Generated at commit: 4b0b6ac312f8f8354ba4fb2268ca3770876fb545

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
41
48
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik enabled auto-merge March 28, 2024 14:28
@dantaik dantaik requested a review from Brechtpd March 28, 2024 18:28
@davidtaikocha davidtaikocha merged commit 10872d9 into main Mar 29, 2024
11 of 13 checks passed
@davidtaikocha davidtaikocha deleted the basefee_scaled branch March 29, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants