Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(relayer): revert func WaitConfirmations should not wait forever for ethereum.NotFound #16554

Merged

Conversation

xiaodino
Copy link
Contributor

@xiaodino xiaodino commented Mar 28, 2024

Reverts #16547

Synced with @cyberhorsey offline.

The context has a timeout
It will hit the case <-ctx.Done(): and return, after the contet's timeout
not the ethereum RPC's timeout.
ctx, cancelFunc := context.WithTimeout(ctx, time.Duration(p.confTimeoutInSeconds)*time.Second)

@cyberhorsey
Copy link
Contributor

needs title change

@davidtaikocha davidtaikocha changed the title Revert "fix(relayer): func WaitConfirmations should not wait forever for ethereum.NotFound" fix(relayer): revert func WaitConfirmations should not wait forever for ethereum.NotFound Mar 29, 2024
@davidtaikocha davidtaikocha added this pull request to the merge queue Mar 29, 2024
Merged via the queue into main with commit 6ad16f5 Mar 29, 2024
9 of 12 checks passed
@davidtaikocha davidtaikocha deleted the revert-16547-xiaodino/fix-relayer-no-found-process-stuck branch March 29, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants