feat(protocol): remove ETH deposit fees #16634
Conversation
dantaik
changed the title
feat(protocol)!: remove ETH deposit fees
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
| @@ -35,17 +35,11 @@ library TaikoData { | |||
| // The size of the ETH deposit ring buffer. | |||
| uint256 ethDepositRingBufferSize; | |||
| // The minimum number of ETH deposits allowed per block. | |||
| uint64 ethDepositMinCountPerBlock; | |||
| uint64 ethDepositsPerBlock; | |||
There was a problem hiding this comment.
I think we lose backward compatiblity with Hekla with the removal of these:
ethDepositMaxAmount, ethDepositGas, ethDepositMaxFee
because the blockSyncThreshold position within the struct slots will be changed, and we use that in LibVerifying.sol:
if (_lastVerifiedBlockId > lastSyncedBlock + _config.blockSyncThreshold)
There was a problem hiding this comment.
If all smart contracts are updated should be good I guess because will point to the correct location?
There was a problem hiding this comment.
Ah ok, since memory object, right !
There was a problem hiding this comment.
@Brechtpd, @adaki2004 do you prefer the entire EthDeposit feature is removed instead? Now we have our Bridge and it seems nobody used the EthDeposit feature, and the current implementation of this feature also assume the existence of the Bridge. #16638
dantaik
changed the title
|
Closed as I'm in favor of #16638 |
This is based on a feedback from an auditor - he is not a fun of the ETH deposit fee design.
How do you guys like the idea of completely remove the fee and lift the min ETH deposit amount?
BTW, I think these changes are backward compatible so Hekla doesn't need to regenesis. @Brechtpd @davidtaikocha