Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): use signature check to verify if msg.sender is EOA #16641

Merged
merged 16 commits into from
Apr 4, 2024
Merged

fix(protocol): use signature check to verify if msg.sender is EOA #16641

merged 16 commits into from
Apr 4, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 4, 2024 •
edited
Loading

After the next hardfork, tx.origin will always be ms.sender with EIP 7645

@davidtaikocha This change may break compatibility.

@dantaik dantaik marked this pull request as ready for review April 4, 2024 02:37
@dantaik dantaik removed the request for review from Champii April 4, 2024 02:39
@dantaik dantaik changed the title feat(protocol): use signature check to verify if msg.sender is EOA fix(protocol): use signature check to verify if msg.sender is EOA Apr 4, 2024
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 4, 2024 •
edited
Loading

fix(protocol): use signature check to verify if msg.sender is EOA

Generated at commit: dda3de02408b555c75a5c5a500757b42ee563110

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik enabled auto-merge April 4, 2024 06:44
@dantaik dantaik requested a review from adaki2004 April 4, 2024 11:00
@dantaik dantaik added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit b853c08 Apr 4, 2024
10 checks passed
@dantaik dantaik deleted the remove_tx_origin branch April 4, 2024 12:16
@dantaik dantaik restored the remove_tx_origin branch April 4, 2024 12:17
This was referenced Apr 4, 2024
Merged
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 adaki2004 approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @adaki2004 @davidtaikocha