Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blobstorage): isolating tables for no blob data duplication #16702

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat(blobstorage): isolating tables for no blob data duplication #16702

merged 3 commits into from
Apr 10, 2024

Conversation

k-kaddal
Copy link
Contributor

@k-kaddal k-kaddal commented Apr 9, 2024

This pr handles solution to avoid blob data duplication, by splitting the blob_hashes table into blob_hashes and blocks_meta tables.

  • Database migration: creating blocks_meta table and migrating data
  • Database migration: creating a new blob_hashes table with unique blob_hash, migrating old data to the new blob_hashes
  • Implementing a BlocksMetaRepository
  • Implementing a database transaction for storing the blob and block data
  • Implementing a database transaction for deleting blobs and blocks based on the blockId
  • Fixing the indexer accordingly

@k-kaddal k-kaddal self-assigned this Apr 9, 2024
@k-kaddal k-kaddal changed the title feat(blobstorage): database migration for creating blocks_meta table … feat(blobstorage): isolating tables for no blob data duplication Apr 9, 2024
@cyberhorsey cyberhorsey added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit 55426ef Apr 10, 2024
6 checks passed
@cyberhorsey cyberhorsey deleted the feat/blobstorage-blocks_meta-table branch April 10, 2024 18:07
@taiko-kitty taiko-kitty mentioned this pull request Apr 10, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@cyberhorsey cyberhorsey cyberhorsey approved these changes

@dionysuzx dionysuzx Awaiting requested review from dionysuzx

@xiaodino xiaodino Awaiting requested review from xiaodino

Assignees

@k-kaddal k-kaddal

Labels
area.event-indexer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-kaddal @davidtaikocha @cyberhorsey