Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(blobstorage): covering tests for BlockMetaRepo, BlobHashRepo and… #16795

Closed
wants to merge 7 commits into from
Closed

feat(blobstorage): covering tests for BlockMetaRepo, BlobHashRepo and… #16795

wants to merge 7 commits into from

Conversation

k-kaddal
Copy link
Contributor

@k-kaddal k-kaddal commented Apr 22, 2024 •
edited
Loading

This PR is covering:

  • handle blob duplication
  • backoff retry for GetBlob
  • db migration allowing block_meta duplication
  • unit tests for BlockMetaRepo, BlobHashRepo and Database transactions

@k-kaddal k-kaddal self-assigned this Apr 22, 2024
@dantaik
Copy link
Contributor

dantaik commented May 22, 2024

@k-kaddal we should close this PR as the blobstorage package has deprecatd. Please re-open this PR if you disagree.

@dantaik dantaik closed this May 22, 2024
@k-kaddal
Copy link
Contributor Author

@k-kaddal we should close this PR as the blobstorage package has deprecatd. Please re-open this PR if you disagree.

@dantaik agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@YoGhurt111 YoGhurt111 Awaiting requested review from YoGhurt111

Assignees

@k-kaddal k-kaddal

Labels
area.blob-storage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-kaddal @dantaik @davidtaikocha @cyberhorsey