-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol): change to transfer and mint pattern with BridgedERC20 tokens #16796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaki2004
requested review from
KorbinianK,
Brechtpd,
dantaik and
davidtaikocha
April 22, 2024 12:32
fix(protocol): change to transfer and mint pattern with BridgedERC20 tokens
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
requested changes
Apr 22, 2024
@dantaik if urgent please proceed with the changes. I'm currently alone with the kid, cannot code in the next 3 hours. |
dantaik
reviewed
Apr 23, 2024
dantaik
reviewed
Apr 23, 2024
dantaik
reviewed
Apr 23, 2024
dantaik
approved these changes
Apr 23, 2024
davidtaikocha
approved these changes
Apr 23, 2024
This was referenced Apr 23, 2024
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dantaik This is the one with "transfer and burn" functionality. The original
burn()
function also stayed as is, because during token migration, that one will be used by end-users - but Vault uses know the sameburn(uint)
interface as USDC.One important side-note to @KorbinianK is, that since we dont
burn
directly buttransfer AND burn
, anapproval
is now again required to bridge back the bridged tokens !