Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): change to transfer and mint pattern with BridgedERC20 tokens #16796

Merged
merged 12 commits into from
Apr 23, 2024

Conversation

adaki2004
Copy link
Contributor

@dantaik This is the one with "transfer and burn" functionality. The original burn() function also stayed as is, because during token migration, that one will be used by end-users - but Vault uses know the same burn(uint) interface as USDC.

One important side-note to @KorbinianK is, that since we dont burn directly but transfer AND burn, an approval is now again required to bridge back the bridged tokens !

Copy link

openzeppelin-code bot commented Apr 22, 2024

fix(protocol): change to transfer and mint pattern with BridgedERC20 tokens

Generated at commit: d2827252aad9aafbba284ceeda33c1be96163f5a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
4
39
47
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the base branch from delete_adaptor to main April 22, 2024 13:55
@adaki2004
Copy link
Contributor Author

@dantaik if urgent please proceed with the changes. I'm currently alone with the kid, cannot code in the next 3 hours.

@dantaik dantaik added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 75841ec Apr 23, 2024
10 checks passed
@dantaik dantaik deleted the change_burn_interface_for_bridgedERC20 branch April 23, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants