-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(supplementary-contracts): add TokenUnlocking to supplementary #16824
Conversation
This reverts commit 5366a3b.
v1.8.1
@dantaik No idea why it shows so many diffs.. I based my branch off of this, could you please resolve this issue or let me know how can i ? |
feat(supplementary-contracts): add TokenUnlocking to supplementary
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
You should create a new PR off the main branch, copy your new files there and compile. We shall also use the npm to manage contracts dependency without using forge's |
Added the first version of
TokenUnlocking
contract.Pretty simple, but there are some
todo
, please search for that text.So my question (i also asked in discord DM):
Base situation, per those quarterly/half-yearly unvesting and it’s excersise :
But the question here is: Is Bob really paying OR he acknowledges that he wants to get those tokens and he will pay once he will withdraw ?
costToWithdraw
andcostToken
variables, because the purchase notice has to be paid before the vested amount is deposited into the contract. (If so, i have to remove them and contract gets simpler).OR
And in the situation above steps nr. 1 & 2 is just a "YES-I-ACKNOWEDGE-I-WANT-MY-TOKENS", but Bob does not have to pay immediately (just at withdrawal).
Somewhat i'm kind of in favor of the second version, because of the following reason: