-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): introduce message.processor
#16999
Conversation
Co-authored-by: D <[email protected]>
…into rate_limiter
This reverts commit b86fd6b.
Should this be configurable by the user or fixed behind the scene to our relayer? If the first, this requires changes to the bridge flow, new views and logic. Doable but will cost time. The second would be a small change on the UI. But either should be thoroughly tested E2E before launch. |
I think using PBS is still greatly preferred because it's the only mechanism that allows 100% protection of the relayer (currently the dest owner can still create difficulties). And because the proposer also requires hooking into PBS, I think having the relayer do the same shouldn't be much difference (just connect to different RPC server, but unsure how L1 fee payment would have to be changed there if at all without looking into the specifics). However, unlike proposing, bridge transactions also need to be processed on L2 where this type of functionality will highly likely not be available for some time (though a grant was given to make something like this), so some reasonable protections for relayers there without a PBS dependency can make sense in the short term. The approach in this PR is indeed better, but if it's short term I guess mostly depends on how much work the change in this PR brings compared to the other. |
Seems fine to me if it would be fixed because it goes through our UI and our fee estimation, maybe it only needs to be a different value for other UIs? |
It should be set by the UI/relayer directly without the user's awareness. If someone set up another dapp to help users send/process messages, that app can set the processor to another value. |
In terms of implementation, I think this should be easy. I think even with PBS, we may still want this feature so that even if someone can get transaction inclusion promise from PBS he/she cannot steal messages that sets processor to another address. |
Guys, shall we merge this PR please? Need a quick decision here. |
Not sure if we will even need it because I'm not expecting many relayer competitions tbh, but if you are, we can merge it and I can update relayer and korbi can do UI. |
Maybe we should also have a poll for this one. @Brechtpd @adaki2004 @cyberhorsey @KorbinianK please vote against/for it. 👍 or 👎 please |
Allow the Bridge UI to set
message.processor
so only this address andmessage.destOwner
can process the message on the destination chain.