-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(taiko-client): change guardian provers to directly submit proofs instead of contests #17069
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17069 +/- ##
===========================================
+ Coverage 26.82% 48.35% +21.53%
===========================================
Files 105 57 -48
Lines 6188 5780 -408
===========================================
+ Hits 1660 2795 +1135
+ Misses 4348 2683 -1665
- Partials 180 302 +122
☔ View full report in Codecov by Sentry. |
Gavin, I think when we have zk proofs, there should be a minimum delay before guardian prover submits a proof, to give regular prover a chance to submit valid proofs. |
Yes, we did. Either sgx or zk proofs, guardian prover will not submit proof until the current time is greater than In the above guardian prover workflow, I focused on the guardian prover's behavior when receiving events and put the logic about delaying into |
packages/taiko-client/prover/proof_submitter/proof_submitter.go
Outdated
Show resolved
Hide resolved
packages/taiko-client/prover/proof_submitter/proof_submitter.go
Outdated
Show resolved
Hide resolved
… instead of contests (#17069) Co-authored-by: maskpp <[email protected]> Co-authored-by: David <[email protected]>
Description
Clarify responsibilities between components.
1.1. Event-handler just handles behavior when receiving various events, including submitting proof, submitting a contest, or doing nothing.
1.2. Proof-submitter chooses how to submit proof and whether to use delay.
Guardian prover workflow